compiler: Revamp bug-async-degree opt-option - #3023
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
+ Coverage 83.89% 83.94% +0.04%
==========================================
Files 258 258
Lines 55605 55676 +71
Branches 4765 4772 +7
==========================================
+ Hits 46652 46738 +86
+ Misses 8135 8124 -11
+ Partials 818 814 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
EdCaunt
reviewed
Sep 9, 2026
Comment on lines
+266
to
+270
| async_degree = oo['buf-async-degree'] | ||
| if async_degree is not None and ( | ||
| isinstance(async_degree, bool) or | ||
| not is_integer(async_degree) or async_degree < 0 | ||
| ): |
Contributor
There was a problem hiding this comment.
Is there some way to express this more concisely?
|
|
||
|
|
||
| def test_read_only_backwards(): | ||
| @pytest.mark.parametrize('async_degree', [None, 4]) |
Contributor
There was a problem hiding this comment.
Should another check be added to this test to ensure this parameterisation results in the desired effect in the gencode?
FabioLuporini
force-pushed
the
revamp-buf-async-degree
branch
from
September 21, 2026 15:01
69843a7 to
f8d6e0f
Compare
FabioLuporini
force-pushed
the
revamp-buf-async-degree
branch
from
September 21, 2026 16:18
f8d6e0f to
a812d79
Compare
EdCaunt
reviewed
Sep 22, 2026
| """Extend `ispace` to include `f`'s HALO.""" | ||
| def _include_halo(ispace, f, dims=None): | ||
| """Extend `ispace` to include `f`'s HALO along `dims`.""" | ||
| dims = f.dimensions if dims is None else dims |
Contributor
There was a problem hiding this comment.
dims = dims or f.dimensions?
mloubout
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.