feat: add check-name so each run posts its own PR check - #45
Merged
Conversation
A PR that submits twice — iOS and Android, say — got two GitHub checks with the same name. Nothing in the PR list tells them apart, and because GitHub matches required checks by name, branch protection can only hold one entry for both: the gate follows whichever run finished last, so a green Android can clear what a red iOS should have held. check-name rides the existing github-context metadata as gh_check_name; the backend appends it to the base name, giving "DeviceCloud / iOS". Unset, the check name is unchanged, so no existing branch-protection rule moves. Warns when check-name is set with include-github-context off — there is no commit context then, so no check is posted at all and the input would otherwise look like it had done something. dist is rebuilt here because CI only builds it on main, and the e2e runs the action from this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR that submits twice — iOS and Android, say — got two GitHub checks with the same name. Nothing in the PR list tells them apart, and because GitHub matches required checks by name, branch protection can only hold one entry for both: the gate follows whichever run finished last, so a green Android can clear what a red iOS should have held.
check-name rides the existing github-context metadata as gh_check_name; the backend appends it to the base name, giving "DeviceCloud / iOS". Unset, the check name is unchanged, so no existing branch-protection rule moves.
Warns when check-name is set with include-github-context off — there is no commit context then, so no check is posted at all and the input would otherwise look like it had done something.
dist is rebuilt here because CI only builds it on main, and the e2e runs the action from this branch.