use stock golangci-lint from nixpkgs - #103
Merged
Merged
Conversation
- drop the overlay now that unstable ships 2.13.1 - keep gofmt on the pinned go 1.27 toolchain - switch isBrokenPipe to errors.AsType and restore SA4023
atkrad
added
kind/chore
github-actions
Bot
added
area/cli
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go_1_27toolchain (defaultgois still 1.26)isBrokenPipetoerrors.AsTypeand restore staticcheck SA4023Test plan
internal/cmd/shelltests;nix run .#test-unit1639 passed)scenarios/(if behavior changes)nix run .#lint/ pre-commit cleanAlso ran
nix flake check --no-build.Labels
kind/feature,kind/bug,kind/docs,kind/chorebreaking-changeif this breaks existing CLI or config behaviorskip-changelogfor internal-only PRs that should not appear in notesChecklist
README.md,docs/cli/)