Skip to content

suunto_nautic: begin pressure = max reading (ignore transmitter dropout) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
latishab merged 1 commit into from
Sep 6, 2026
Merged

suunto_nautic: begin pressure = max reading (ignore transmitter dropout) #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/suunto_nautic_parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,13 +555,22 @@ suunto_nautic_parser_parse (dc_parser_t *abstract, dc_sample_callback_t callback
// Cylinder slot index == GasNumber, so this tank
// breathes gas i (linked to gasmix[i] below).
tank[ntanks].gasmix = i;
// Begin from the first observed reading (the deferred one for Pressure2).
// Seed begin from the first observed reading (the deferred
// one for Pressure2); refined to the max below.
tank[ntanks].beginpressure = (field == 1 && p2_first[i] >= 0)
? p2_first[i] / 100000.0 : bar;
ntanks++;
}
unsigned int t = (unsigned int) tankmap[key];
tank[t].endpressure = bar;
// Begin pressure = the highest reading seen: a cylinder only
// loses pressure during a dive, so the max is the true start.
// This ignores an initial dropout where a transmitter that
// hasn't paired yet reports a spurious low value (e.g. ~9 bar
// for the first minutes, then jumps to the real ~200 bar --
// nandodiver's dual-transmitter dives, issue #29/#34).
if (bar > tank[t].beginpressure)
tank[t].beginpressure = bar;
if (callback) {
dc_sample_value_t sample = {0};
sample.time = (unsigned int) time_ms;
Expand Down
Loading