dbeaver/pro#4858 Add data import format preferences - #4674
Open
sergeyteleshev wants to merge 7 commits into
Open
sergeyteleshev wants to merge 7 commits into
sergeyteleshev wants to merge 7 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
sergeyteleshev
requested review from
devnaumov
and
a lite review from Copilot
September 18, 2026 15:22
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Add an explicit aria-label to the icon-only file removal button.
Pull request overview
Adds configurable import format preferences with tabbed navigation, localization, and API propagation.
Changes:
- Loads and displays editable processor properties.
- Adds File and Format tabs with state preservation.
- Passes format overrides to the import API.
- Adds dependency wiring and localization updates.
File summaries
| File | Summary |
|---|---|
webapp/yarn.lock |
Updates dependency metadata. |
webapp/packages/plugin-data-import/tsconfig.json |
Adds the core-ui project reference. |
webapp/packages/plugin-data-import/src/locales/ru.ts |
Adds Russian labels. |
webapp/packages/plugin-data-import/src/locales/en.ts |
Adds English labels. |
webapp/packages/plugin-data-import/src/DataImportService.ts |
Sends processor properties to the API. |
webapp/packages/plugin-data-import/src/DataImportDialog/useDataImportDialog.ts |
Manages dialog state and navigation. |
webapp/packages/plugin-data-import/src/DataImportDialog/IDataImportDialogState.ts |
Defines dialog state. |
webapp/packages/plugin-data-import/src/DataImportDialog/EDataImportDialogTab.ts |
Defines dialog tabs. |
webapp/packages/plugin-data-import/src/DataImportDialog/DataImportFileSelector.tsx |
Implements file selection controls. |
webapp/packages/plugin-data-import/src/DataImportDialog/DataImportFileSelector.module.css |
Styles file selection. |
webapp/packages/plugin-data-import/src/DataImportDialog/DataImportFileItem.tsx |
Renders selected files and removal controls. |
webapp/packages/plugin-data-import/src/DataImportDialog/DataImportFileItem.module.css |
Styles file items. |
webapp/packages/plugin-data-import/src/DataImportDialog/DataImportDialog.tsx |
Implements the tabbed import dialog. |
webapp/packages/plugin-data-import/src/DataImportDialog/DataImportDialog.module.css |
Styles the dialog. |
webapp/packages/plugin-data-import/src/DataImportBootstrap.ts |
Passes dialog properties to import execution. |
webapp/packages/plugin-data-import/package.json |
Adds the core-ui dependency. |
webapp/packages/core-sdk/src/queries/data-transfer/getDataTransferImportProcessors.gql |
Requests processor property metadata. |
Review details
Suppressed comments (1)
webapp/packages/plugin-data-import/src/DataImportDialog/DataImportFileItem.tsx:32
titleis only a tooltip and does not reliably provide an accessible name for this icon-only button. Since this change is intended to make the file controls accessible, add anaria-label(as done forInputFiles) so screen readers announce which file will be removed.
<ActionIconButton name="cross-bold" title={`${translate('ui_remove')}: ${name}`} disabled={disabled} onClick={() => onDelete(id)} />
- Files reviewed: 16/17 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes dbeaver/pro#4858
Summary
Verification
yarn workspace @cloudbeaver/plugin-data-import build— passed.yarn lint packages/plugin-data-import/src/ --ext .ts,.tsx— passed with two existing warnings.git diff --check— passed.