Fail closed on unsafe incremental resumes - #57
Open
davanstrien wants to merge 5 commits into
Open
davanstrien wants to merge 5 commits into
davanstrien wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy incremental runs could reuse verdicts after source data, OCR output selection, or judge settings changed. This PR stamps every comparison and checkpoint with per-pair provenance and stops unsafe resumes before reusing those verdicts.
--full-rejudgeor a new results repository for legacy unstamped or mismatched current-grid comparisons. Preserve historical comparisons outside the current rankable grid.Updated against current
main, including merged #55 and #56. The #55 model/output resolver now also supplies the original OCR column to provenance, so switching output columns is detected even when their text and model identity are identical. The README documents the migration.Validation: 651 tests passed locally; Ruff, ty, and
git diff --checkpassed. Regression coverage includes unchanged config resumes, adding a new model, incomplete appended inference metadata, changed output columns/text/judge/split, legacy results, and comparisons-only checkpoints.