refactor(datafusion-flight-sql-server): remove tokio-stream listener … - #58
Merged
Conversation
…wrapper Introduce a generic `serve_with_incoming` entrypoint and route the listener-based server startup through tonic's `TcpIncoming`. This keeps the existing listener API intact while dropping the direct `tokio-stream` dependency and reducing the server's wrapper glue.
hozan23
approved these changes
Aug 5, 2026
Collaborator
|
Thanks @cloneyate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The previous serve_with_listener implementation used TcpListenerStream, bypassing tonic's accepted-socket configuration. In particular, TCP_NODELAY was
not enabled, unlike the standard serve path. This could introduce Nagle/delayed-ACK latency for Flight SQL workloads.
Using TcpIncoming keeps serve_with_listener consistent with serve, while serve_with_incoming supports broader use cases such as custom TCP settings,
connection wrappers, TLS transports, and alternative incoming streams.