Fix LegacyConfigConverter mutating caller-shared configs - #2260
Open
rafal-hawrylak wants to merge 1 commit into
Open
Fix LegacyConfigConverter mutating caller-shared configs#2260rafal-hawrylak wants to merge 1 commit into
rafal-hawrylak wants to merge 1 commit into
Conversation
Shallow-clone .bigquery and .assertions before in-place coercions so
`publish("t1", shared); publish("t2", shared);` no longer leaves t2/t3
with an empty bigquery block. Regression from #1780 (3.0.10).
core/actions/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shallow-clone .bigquery and .assertions before in-place coercions so
publish("t1", shared); publish("t2", shared);no longer leaves t2/t3 with an empty bigquery block. Regression from #1780 (3.0.10).core/actions/index.ts