removed golden summary - #2214
Open
niveditasing wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the FBI hate crime aggregations configuration by adding a node_mcf entry to the manifest and modifying the validation configuration, which includes increasing the deleted records threshold and removing the golden summary report check. The feedback suggests explicitly specifying aggregation.mcf instead of using a wildcard to ensure robustness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we increased the deletion threshold to 0.3:
The deletions reflect genuine upstream historical corrections and auditing by the FBI across reporting agencies, rather than an extraction bug. Raising the threshold to 0.3 accommodates these legitimate agency revisions (<0.14%) without failing future runs, while retaining a safety boundary against large-scale data drops.
Why we removed
golden_summary.csv(check_goldens_summary_report):FBI hate crime reporting coverage naturally grows over time as additional law enforcement agencies transition to NIBRS and submit incident data. Testing against a static golden summary report causes recurrent false-positive validation failures whenever agency participation and place counts expand.