Chnages - #2213
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the "validation_config_file" property from the BIS central bank policy rate manifest. The reviewer correctly points out that removing this configuration disables crucial validation checks (such as SQL validations and golden checks), which could lead to undetected data quality issues, and recommends retaining it.
| ], | ||
| "cron_schedule": "0 05 * * 6", | ||
| "validation_config_file": "validation_config.json" | ||
| "cron_schedule": "0 05 * * 6" |
There was a problem hiding this comment.
Removing the validation_config_file reference disables all validation checks (such as SQL validations, golden checks, and deletion thresholds) defined in validation_config.json. This can lead to undetected data quality issues or corrupted imports. Please retain the validation configuration reference unless there is a specific reason to disable these checks.
"cron_schedule": "0 05 * * 6",
"validation_config_file": "validation_config.json"1 participant
No description provided.