OECDRegionalDemography_Population| Fixed missing data issue - #2152
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces new statistical variables for age groups 20-64, 25-54, and 55-64, including gender-specific breakdowns, and updates the associated column mappings and golden data. Additionally, a new validation configuration file is added to the manifest. The reviewer recommended updating the rule_id in the validation configuration for consistency and noted that the expected test files must be updated to reflect these schema changes to prevent unit test failures.
Removed validation rules related to golden records checks.
Removed the check_max_date_consistent validation rule from the configuration.
|
Can we pls run differ to validated our changes |
Please find the attached differ_summary report |
|
/gcbrun |
|
/gcbrun |
This PR is raised to fix validation failure in OECDRegionalDemography_Population job due to change in working age cohorts in upstream source.
Support broad working-age cohorts (20-64, 25-54, 55-64) in OECD Regional Demography Population
Add support for OECD regional demography broad working-age population cohorts:
Test result:
Test Cloud Batch Job
Test GCS Bucket
CL link