Added validation configuration for EPA_airqualityindex - #2147
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces golden data validation for the US EPA Air Quality Index script. It adds golden observation and summary report CSV files, configures a new validation_config.json with validation rules (such as checking deleted records percentage and verifying output data against the golden datasets), and updates the manifest to include these new files and validation configurations while adjusting resource limits. I have no feedback to provide as there are no review comments.
|
@shourya116 Please reply to comments suggeted by pulkeet . also take reference from #2193 and add details like that . |
Code Review Summary (LGTM with 1 PR Description Hygiene Note)Reviewed HEAD commit
Action Items Before Merge:
|
shourya116
left a comment
There was a problem hiding this comment.
comment addressed
shourya116
left a comment
There was a problem hiding this comment.
resolved comments
|
/gcbrun |
Added validation configuration for EPA_AirQualityIndex. Job ran successfully.
Files updated are : manifest.json, validation_config.json, EPA_AQI.mcf
GCS Bucket
Cloud Batch Job