Skip to content

issue 275 fixed - #279

Merged
monrog2 merged 5 commits into
v4.3.0-devfrom
issue275
Sep 18, 2026
Merged

monrog2 merged 5 commits into
v4.3.0-devfrom
issue275

Conversation

@jeestr4d

@jeestr4d jeestr4d commented Aug 15, 2025

Copy link
Copy Markdown
Collaborator

issue #275 fixed.

lab test, changed from eq=auto to ne=auto , to have test output:

[Check 62/87] Host Interface Policy policy Set... FAIL - OUTAGE WARNING!!
Host Interface Policy Set Speed Policy Groups associated


uni/infra/hintfpol-100G_test1-49 100G ar_fec_test
uni/infra/hintfpol-10gb_fixed 10G N/A
uni/infra/hintfpol-AUTO inherit av-access
uni/infra/hintfpol-AUTO inherit av_accessB
uni/infra/hintfpol-EXAMPLE 40G PRUEBA
uni/infra/hintfpol-default inherit 1_10
uni/infra/hintfpol-default inherit 1_12
uni/infra/hintfpol-default inherit 698943766
uni/infra/hintfpol-default inherit 698943766-105
uni/infra/hintfpol-default inherit 698943766-106
uni/infra/hintfpol-default inherit 698943766-107
uni/infra/hintfpol-default inherit AEPFER
uni/infra/hintfpol-default inherit All_Purpose_PG

local pytest:

jeestrad@JEESTRAD-M-L6VV ACI-Pre-Upgrade-Validation-Script % python3 -m pytest tests/host_interface_policy_set_speed_check
======================================================================== test session starts =========================================================================
platform darwin -- Python 3.9.6, pytest-8.2.0, pluggy-1.5.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
plugins: anyio-4.8.0
collected 3 items

tests/host_interface_policy_set_speed_check/test_host_interface_policy_set_speed_check.py::test_logic[icurl_outputs0-None-MANUAL CHECK REQUIRED]
--------------------------------------------------------------------------- live log setup ---------------------------------------------------------------------------
[17:49:51.554 INFO initialize:5357] Cleaning up previous run files in preupgrade_validator_logs/
[17:49:51.559 INFO initialize:5359] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
PASSED [ 33%]
tests/host_interface_policy_set_speed_check/test_host_interface_policy_set_speed_check.py::test_logic[icurl_outputs1-6.0(9d)-FAIL - OUTAGE WARNING!!] PASSED [ 66%]
tests/host_interface_policy_set_speed_check/test_host_interface_policy_set_speed_check.py::test_logic[icurl_outputs2-6.0(1g)-PASS] PASSED [100%]

========================================================================= 3 passed in 0.03s ==========================================================================

Fixes #275

@jeestr4d
jeestr4d requested review from monrog2 and takishida August 15, 2025 23:52
@monrog2
monrog2 changed the base branch from master to v4.1.0 February 27, 2026 16:17

@monrog2 monrog2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation applies FAIL_O to every in-use host interface policy whose speed is set to auto, regardless of hardware or topology. However, the authoritative CSCwh11580 defect record limits the trigger to an ACI leaf connected to an N9K-C9372-PX. As written, unaffected fabrics will receive a critical outage warning.

Please restrict FAIL_O to the verified defect conditions. Generic speed="auto" best-practice violations can instead be reported as MANUAL. Please also document the CSCwh11580 scope and add tests covering affected and unaffected hardware, including the result payload—not only the status.

The linked Cisco guide does support recommending inherit, and the Python 2.7/3.8 CI checks pass. The PR currently conflicts with its base, so the resolved merge diff will also need validation.

@monrog2
monrog2 changed the base branch from v4.1.0-dev to v4.2.0-dev July 21, 2026 19:47
@lovkeshsharma702
lovkeshsharma702 deleted the branch v4.3.0-dev September 9, 2026 09:19
@monrog2 monrog2 reopened this Sep 9, 2026
@monrog2
monrog2 changed the base branch from v4.2.0-dev to v4.3.0-dev September 9, 2026 13:28
monrog2 and others added 3 commits September 15, 2026 10:26
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@monrog2

monrog2 commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Host Interface Policy Set to Auto — integration test summary

The updated check executed on 15 fabrics:

Result Count
PASS 14
FAIL - OUTAGE WARNING 1
MANUAL 0
ERROR 0

Positive detection

One fabric contained an in-use host interface policy configured with speed="auto":

Host Interface Policy  Set Speed  Associated Interface Policy Group  Group Type
---------------------  ---------  ---------------------------------  -----------
<redacted-policy>      auto       <redacted-policy-group>            PC/vPC
<redacted-policy>      auto       <redacted-policy-group>            Leaf Access

Summary

  • The policy was correctly identified as being consumed by two interface policy groups.
  • Both policy-group types were classified correctly.
  • The previous N/A output for the PC/vPC group was resolved.
  • The remaining 14 fabrics passed.
  • No check-specific parsing errors, manual results, or unexpected exceptions occurred.
  • Unused policies configured with speed="auto" were not reported, as designed.

…olution

# Conflicts:
#	aci-preupgrade-validation-script.py
#	docs/docs/validations.md
@monrog2
monrog2 merged commit d239569 into v4.3.0-dev Sep 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NewValidation: Check for CSCwh11580 / interfaces with link speeds "auto"

3 participants