Revert usage of RedactSensitiveFields - #6179
Open
andrewnester wants to merge 3 commits into
Open
Conversation
andrewnester
enabled auto-merge
August 5, 2026 15:52
janniklasrose
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Revert usage of RedactSensitiveFields
Why
RedactSensitiveFields (added in #5896, merged 2026-07-22) deep-clones the state struct field-by-field via reflection, then marshals the clone. The clone skips unexported fields (libs/structs/structwalk/redact.go:44-46), and duration.Duration stores its whole value in an unexported field while marshalling through a custom MarshalJSON
So on main, every duration written to the direct-engine state file is silently corrupted to 0s.
Tests
Golden fiels updated