Skip to content

feat: add enforceUniqueInstanceId option to orchestration and workflow instances - #1803

Merged
javier-aliaga merged 1 commit into
dapr:masterfrom
matheusandre1:issue1801
Sep 3, 2026
Merged

feat: add enforceUniqueInstanceId option to orchestration and workflow instances#1803
javier-aliaga merged 1 commit into
dapr:masterfrom
matheusandre1:issue1801

Conversation

@matheusandre1

Copy link
Copy Markdown
Contributor

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will Closes: #1801

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@matheusandre1
matheusandre1 marked this pull request as ready for review September 3, 2026 03:59
@matheusandre1
matheusandre1 requested review from a team as code owners September 3, 2026 03:59
@javier-aliaga

Copy link
Copy Markdown
Contributor

thanks @matheusandre1 ! Can you modify the class WorkflowInstanceAlreadyExistsException.java so the docs make clear that this is throw not only for active workflows? with this new optin true it fails with any status

…w instances

Signed-off-by: Matheus André <matheusandr2@gmail.com>
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.17%. Comparing base (4192ca9) to head (2cf8c73).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1803      +/-   ##
============================================
+ Coverage     77.15%   77.17%   +0.02%     
- Complexity     2317     2324       +7     
============================================
  Files           245      245              
  Lines          7186     7198      +12     
  Branches        750      750              
============================================
+ Hits           5544     5555      +11     
- Misses         1281     1283       +2     
+ Partials        361      360       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@javier-aliaga
javier-aliaga merged commit 8f3cd62 into dapr:master Sep 3, 2026
15 of 16 checks passed
@javier-aliaga javier-aliaga added this to the v1.19 milestone Sep 3, 2026
@matheusandre1
matheusandre1 deleted the issue1801 branch September 3, 2026 14:43
@matheusandre1

Copy link
Copy Markdown
Contributor Author

Thanks @javier-aliaga!

@marcduiker

Copy link
Copy Markdown
Contributor

@holopin-bot @matheusandre1 sdk-badge Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot

holopin-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

Congratulations @matheusandre1, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmtr0q9me0003ld04417kjatd

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add enforceUniqueInstanceId option when scheduling workflows

3 participants