Feature/1794 workflow list history rerun - #1798
Open
siri-varma wants to merge 14 commits into
Open
Conversation
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
…1794) Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
…apr#1794) Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
…r#1794) Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
…nt (dapr#1794) Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
…apr#1794) The management example ran the client as a separate dapr app (demoworkflowclient), so its DaprWorkflowClient scheduled workflows against demoworkflowclient workflow actors that no worker hosts. The sidecar looped on DaprBuiltInActorNotFoundRetries until the mm.py step timed out, failing the validate job. Pin the worker sidecar to --dapr-grpc-port 50003 and run the client as a plain java -jar that connects to that port, then dapr stop the worker. This matches the working chaining/faninout patterns and also stops the leftover worker sidecar that broke the CI retry attempt. Port 50003 is a free daprd gRPC port; 50005 is reserved by the dapr placement service. Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
dapr#1794) The build-durabletask job is capped at 7 min (5 min per test step) and runs against the durabletask-go sidecar. The four added ITs used the class-level 100s waitForInstanceCompletion ceiling; the two rerun tests waited on rerun-from-eventID-0 instances that never complete on that sidecar, blocking ~100s each and pushing the suite from ~5 min to over 7 min, so the job was killed. The listInstanceIds pagination loop was a second hang risk (no iteration cap). Remove the four ITs. The feature stays covered by DaprWorkflowClientTest unit tests; user-facing integration coverage belongs in sdk-tests against a full Dapr runtime (which supports rerun), not the minimal durabletask-go sidecar. Keeps the null-input guard from cfdfff6. Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
siri-varma
force-pushed
the
feature/1794-workflow-list-history-rerun
branch
from
September 8, 2026 14:26
f44c0b7 to
ac9b8f6
Compare
siri-varma
marked this pull request as ready for review
September 8, 2026 14:27
…dapr#1794) The client reran from history.get(0), the WorkflowStarted lifecycle event, whose event ID is -1. daprd rejects it: 'target event HistoryEvent_WorkflowStarted with ID -1 is not an event that can be rerun'. Lifecycle/result events carry event ID -1; only scheduling events (e.g. the activity's TASK_SCHEDULED) have a non-negative ID and are valid rerun targets. Select the first history event with a non-negative event ID as the rerun target, which matches the overwriteInput semantics (rerun that activity with new input). Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1798 +/- ##
============================================
+ Coverage 77.10% 77.41% +0.31%
- Complexity 2317 2376 +59
============================================
Files 245 250 +5
Lines 7186 7294 +108
Branches 750 754 +4
============================================
+ Hits 5541 5647 +106
Misses 1284 1284
- Partials 361 363 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1794
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: