fix(deps): resolve Dependabot alerts #402, #403, #404, #405, #406 - #164
Merged
Conversation
…2-#406 Move @xmldom/xmldom 0.8.14 -> 0.8.15 (GHSA-6gmq-8vp8-gcm6) and fast-uri 3.1.5 -> 3.1.6 (GHSA-jqff-g426-hqxp, GHSA-fph4-wmhf-6fwf, GHSA-f65p-4m7j-42xc, GHSA-5jgf-p345-68v8). Both are transitive dev dependencies of electron-builder; only the lockfile changes.
📊 Coverage Report
|
🧪 E2E Test Results✅ 36 passed, 0 failed, 0 skipped
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alerts
@xmldom/xmldom— XML fragment injection viaEntityReference.nodeNameunderrequireWellFormedserialization. The repo does not import xmldom; it is reached only throughplistinsideapp-builder-lib(electron-builder), which writes its own generated plist documents. The repo never callscreateEntityReference, so the vulnerable path is not reachable from this codebase.fast-uri— host confusion via percent-encoded scheme normalization. Not reached:fast-uriis only used byajvinsideapp-builder-libto resolve$refs in the static electron-builder config schema; no untrusted URIs are involved.fast-uri— SSRF via repeated hostname percent-decoding. Not reached, same path as #403.fast-uri— SSRF via malformed IPv6 normalization. Not reached, same path as #403.fast-uri— host confusion via skipped IDN canonicalization. Not reached, same path as #403.Both packages are development-scope transitives of
electron-builder@26.15.7(electron-builder > app-builder-lib > plist > @xmldom/xmldomandelectron-builder > app-builder-lib > ajv > fast-uri). Nothing undersrc/references either package.Changes
@xmldom/xmldom0.8.14 -> 0.8.15 (clears #402). Parentplist@3.1.0requires^0.8.8, so the lockfile entry alone moves. 0.8.15 is the lowest patched release on the 0.8 line.fast-uri3.1.5 -> 3.1.6 (clears #403, #404, #405, #406). Parentajv@8.20.0requires^3.0.1, so the lockfile entry alone moves. 3.1.6 is the first patched version; 3.1.7 was deliberately not taken.package.jsonis untouched. No source files changed. No overrides were needed. The lockfile diff is exactly the two entries (version, resolved, integrity), 6 lines each.Verification
npm ci: clean install from the updated lockfile, 720 packages, postinstallelectron-builder install-app-depscompleted.npm run typecheck && npm run test: typecheck (node and web) passed; vitest 83 files, 922 tests, all passed.npm run lint: 0 errors (41 pre-existing warnings, unchanged).npm run build: typecheck pluselectron-vite buildsucceeded.npx electron-builder --dir --publish never: linux x64 unpacked package built successfully. This is the only code path that loadsplist/@xmldom/xmldomandajv/fast-uri, and it ran clean with the new versions.npm auditbefore (main lockfile): 2 vulnerabilities (1 moderate@xmldom/xmldom <=0.8.14, 1 highfast-uri 3.0.0 - 3.1.5covering all four advisories). After:found 0 vulnerabilities.Risk assessment
Changelog review:
@xmldom/xmldom0.8.15: security-only release. Eight fixes (entity-reference, doctype and PI-target validation underrequireWellFormed; quadratic namespace/attribute/whitespace/normalize paths). Release notes state serialized output is byte-identical; the only observable change is a newly reported recoverable parseerrorfor an end tag with trailing content. No API or default changes.plistonly builds and serializes its own documents.fast-uri3.1.6: security release for the four advisories above, plus a batch of RFC 3986 conformance fixes (encoding of serialized components, reserved path characters, percent-escape validation, URN handling, websocket query delimiters, equality case handling). All arefix:commits with no declared breaking change and no API change. The only consumer here isajvresolving$refs in electron-builder's bundled JSON schema, which contains plain relative fragments; the packaging run above confirms schema validation still works.Auto-merge checklist:
Decision
Clear to merge automatically: every condition holds. The version bump, CI, and merge follow.