ci: remove redundant test workflows - #748
Merged
Merged
Conversation
Remove three CI workflows whose checks are fully covered by the local test suite (run per repo policy before every PR): - rust-clippy.yml (clippy + rust-test): the flaky job that was failing PRs with timing races (net_bind rapid-rebind, auto_resume_e2e, codex_fork_rebind) under CI scheduling load. cargo fmt/clippy/test are run locally. - typecheck-client.yml: runs 'npm run typecheck:client', which is part of 'npm run check' (run locally). - port-contract.yml: the TS side (test:port freeze suite + contract:generate idempotency) is now folded into the local default 'npm test' suite (PR #747). The Rust crate checks (cargo test -p freshell-protocol/terminal) remain a separate manual cargo test step. Kept: docs-pages-deploy.yml, electron-build.yml, electron-release.yml (CI-only deploy/build actions, not tests). Also update port/contract/README.md to reflect that the drift guard now runs via the local npm test suite instead of the removed CI workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes three CI workflows whose checks are fully covered by the local test suite (run per repo policy before every PR).
Why
The user is the only committer and runs all tests locally before pushing. The CI test jobs were redundant with local runs, consumed GitHub Actions minutes (budget is low), and the
rust-testjob was flaky (timing races under CI scheduling load — failing PRs that were green locally).Removed
rust-clippy.yml(clippy + rust-test jobs):cargo fmt/clippy/testare run locally. Therust-testjob was the source of the recent CI flakiness (net_bindrapid-rebind,auto_resume_e2e,codex_fork_rebindtiming races).typecheck-client.yml: runsnpm run typecheck:client, which is part ofnpm run check(run locally).port-contract.yml: the TS side (test:portfreeze suite +contract:generateidempotency) was folded into the local defaultnpm testsuite in PR test: fold WS port contract drift guard into local suite #747. The Rust crate checks (cargo test -p freshell-protocol/terminal) remain a separate manualcargo teststep.Kept
docs-pages-deploy.yml— deploysdocs/to GitHub Pages (CI-only action)electron-build.yml— builds Electron app (CI-only, win32 cross-compile)electron-release.yml— uploads installers to GitHub Releases (CI-only)Also
Updates
port/contract/README.mdto reflect that the drift guard now runs via the localnpm testsuite instead of the removed CI workflow.