test: deflake CI rust-test timing (pkvz + dead_session WARN) - #744
Merged
Conversation
danshapiro
force-pushed
the
fix/ci-rust-test-flakes
branch
from
September 7, 2026 19:48
ef30f5f to
2b17bd4
Compare
…N poll) Two rust-test flakes were blocking PR CI on the 4-core GitHub Actions runner (different tests each run, same root: async side-effect lag under workspace-level contention): - codex_locator_activity (kata pkvz): wait_for_frame budget 30s → 120s. The locator adoption sweep latency exceeds 30s under whole-workspace test contention on the CI runner (3+ CI occurrences on different PRs). The test's own send_create also has a 30s FRAME_BUDGET (common/mod.rs) that can expire before the spawn completes under load. - pane_reconcile_freshagent (dead_session WARN): the tracing layer's capture push can lag the client's response read by a scheduling quantum. Replace the immediate assert with a 5s bounded poll of the capture buffer so the test tolerates that lag without masking a genuinely missing log.
danshapiro
force-pushed
the
fix/ci-rust-test-flakes
branch
from
September 7, 2026 19:59
2b17bd4 to
707530c
Compare
pull Bot
pushed a commit
to HinchK/freshell
that referenced
this pull request
Sep 8, 2026
…ck, reconcile 120s budget from PR danshapiro#744
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two rust-test flakes were intermittently blocking PR CI on the 4-core GitHub Actions runner (different tests each run, same root: async side-effect lag under workspace-level contention).
wait_for_framebudget 30s → 120s. The locator adoption sweep latency exceeds 30s under whole-workspace test contention on the CI runner (3+ CI occurrences on unrelated PRs).