fix(ci): --no-fail-fast, deflake remaining sleeper copy, regression test - #733
Merged
Conversation
… add regression test Delta review of PR #724 found four actionable findings: 1. Missing --no-fail-fast: one flake aborted the entire workspace test run, hiding all later test binaries. Add --no-fail-fast so all binaries run. 2. restore_spawn_gate.rs had the same ETXTBSY race as common/mod.rs (shared {name}-{pid} path, 10 parallel tests). Add AtomicU64 counter matching the common/mod.rs fix. 3. No regression test for the shared common::sleeper_cli_spec uniqueness. Add shared_sleeper_cli_spec_paths_are_unique_per_call in pane_ledger_triggers matching the existing test in cross_kind_liveness.rs (commit 1839b11). Kata 299r tracks the auto_resume_e2e timing flakes that block rust-test from going green on 4-core CI runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #724 addressing delta-review findings:
Kata 299r tracks the auto_resume_e2e timing flakes that block rust-test from going green on 4-core CI.