co::Coroutine -> toolbelt::Poller - #27
Open
mikael-s-persson wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor that's been gnawing at me for a while. It feels wrong that toolbelt would depend on coroutine, just to inject a couple of poll-like functions. So, this PR replaces the
co::Coroutine*parameters in the various toolbelt classes to use its owntoolbelt::Pollerabstract base class, whichco::Coroutineinherits from (there will be a corresponding PR in coroutines repo too).I also add, for convenience, a PosixPoller class that implements the interface with vanilla Posix poll calls.
The motivation, other than the mere ideal of separating concerns, is to make toolbelt lighter and not joined-at-the-hip with coroutines, for when they are not used.
It creates a slightly weird situation where both repos depend on each other, but that works because only toolbelt's test targets depend on coroutines.