Harden PayloadBuffer against hostile wire data - #26
Open
dallison wants to merge 2 commits into
Open
Conversation
Add size-aware string readers that clamp stored lengths to the received buffer, fix IsPresent bit indexing, and make IsValidAddress overflow-safe so untrusted payloads cannot cause out-of-bounds reads.
4 tasks
Start-only bounds checks let a uint32_t length word near the end of a hostile buffer through, causing ASan heap-buffer-overflow in BoundedString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetString/GetStringViewoverloads that clamp stored string lengths to the received buffer sizeIsPresentto use 32-bit word indexing (matching setters) with null-safe bounds checksIsValidAddressoverflow-safe by comparing offsets instead of forming out-of-range end pointersHostileStringLengthIsClampedTest plan
bazel test //...(macOS)bazel test //... --config=asan(Linux via Colima)