Fix pica unit parsing in spacing width conversion - #755
Open
moritz-gross wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@NSoiffer I've never heard of "pica" before (or the majority of these other units). This PR came to be as I just let GPT-6 run wild on the codebase to try it out for the first time. This looks like a pretty straightforward and small fix. Still want you to look at this before merging as this is an area of the code I've not yet worked with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MathML space widths expressed in picas, such as
1pc, were interpreted as zero because the unit regex recognizedppcwhile the conversion handledpc. Correct the regex so1pcconverts to1emunder the existing 12-point font estimate, and document the return units and font assumption.Add a regression test covering whole, fractional, and negative pica widths, plus equivalent point and em values. Existing speech and braille expectations are unchanged.
Validation:
cargo test --offline --lib font_size_guess_pica_widthspassed;git diff --checkpassed.