Russian braille: GOST fixes and digit grouping - #716
Merged
Conversation
Implement GOST-related Russian braille changes: update YAML rules to refine contextual bracket/angle recognition and remap numeric/private-use codepoints for periodic/number handling. Add division-sign and arrow mappings and an internal digit-group separator. Modify src/braille.rs to ignore the internal separator when detecting digits, replace it with braille point-3 in cleanup, and add add_russian_digit_group_separators (skip for column-arithmetic) to insert grouping separators only for long integers. Update many Russian braille tests to reflect new numeric grouping, arrow/±/÷ behavior, and bracket recognition across structural boundaries.
Rename Russian braille typeform rules (small-font, letter-spacing, insertion) and relax angle-bracket matching to include legacy 〈/〉 with adjusted test for selection. Add many verified Unicode braille mappings (℉, ∓, ∕, ⁄, arrows, negation, tilde, ⟂, precomposed vulgar fractions, superscript/subscript digits, etc.) in Rules/Braille/Russian/unicode.yaml. Update rus comments in src/braille.rs for clarity. Rename numerous tests to russian_* and add new unit tests for fraction slashes, precomposed fractions, additional symbols, and script digits (tests/braille/Russian/russian.rs).
Collaborator
|
Looks good. This will go into the next release (probably October). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement GOST-related Russian braille changes: update YAML rules to refine contextual bracket/angle recognition and remap numeric/private-use codepoints for periodic/number handling. Add division-sign and arrow mappings and an internal digit-group separator. Modify src/braille.rs to ignore the internal separator when detecting digits, replace it with braille point-3 in cleanup, and add add_russian_digit_group_separators (skip for column-arithmetic) to insert grouping separators only for long integers. Update many Russian braille tests to reflect new numeric grouping, arrow/±/÷ behavior, and bracket recognition across structural boundaries.