Skip to content

fix(google-indexing): treat 403 PERMISSION_DENIED as warning, not failure #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(google-indexing): treat 403 PERMISSION_DENIED as warning, not failure #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/google-indexing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
mode = 'full (manual dispatch)' if full_run else 'latest 2'
print(f'Mode: {mode} — selected {len(targets)} URLs')

submitted, failed = [], []
submitted, failed, warned = [], [], []
for loc in targets:
r = requests.post(
'https://indexing.googleapis.com/v3/urlNotifications:publish',
Expand All @@ -62,6 +62,9 @@ jobs:
if r.status_code == 200:
print(f'OK {loc}')
submitted.append(loc)
elif r.status_code == 403:
print(f'WARN {loc} http=403 (permission denied — check Search Console ownership)')
warned.append((loc, r.status_code, r.text))
else:
print(f'FAIL {loc} http={r.status_code} body={r.text}')
failed.append((loc, r.status_code, r.text))
Expand All @@ -71,6 +74,10 @@ jobs:
print(f'Submitted: {len(submitted)} / {len(targets)}')
for loc in submitted:
print(f' + {loc}')
if warned:
print(f'Warned (403 permission): {len(warned)}')
for loc, code, body in warned:
print(f' ! {loc} (http={code})')
if failed:
print(f'Failed: {len(failed)}')
for loc, code, body in failed:
Expand All @@ -84,6 +91,8 @@ jobs:
fh.write(f'**Submitted:** {len(submitted)} / {len(targets)}\n\n')
for loc in submitted:
fh.write(f'- [x] {loc}\n')
for loc, code, _ in warned:
fh.write(f'- [!] {loc} (http={code} — permission denied)\n')
for loc, code, _ in failed:
fh.write(f'- [ ] {loc} (http={code})\n')

Expand Down