Skip to content

Firo: recognize Spark V2 spend transactions #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julian-CStack merged 1 commit into from
Sep 4, 2026
+17 −1
Merged

Firo: recognize Spark V2 spend transactions #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/wallets/wallet/impl/firo_transaction_type.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
bool isSparkSpendTransaction(Map<String, dynamic> transaction) {
final type = transaction['type'];
return transaction['version'] == 3 && (type == 9 || type == 11);
}
3 changes: 2 additions & 1 deletion lib/wallets/wallet/impl/firo_wallet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import '../wallet_mixin_interfaces/coin_control_interface.dart';
import '../wallet_mixin_interfaces/electrumx_interface.dart';
import '../wallet_mixin_interfaces/extended_keys_interface.dart';
import '../wallet_mixin_interfaces/spark_interface.dart';
import 'firo_transaction_type.dart';

class MasternodeInfo {
final String proTxHash;
Expand Down Expand Up @@ -332,7 +333,7 @@ class FiroWallet<T extends ElectrumXCurrencyInterface> extends Bip39HDWallet<T>
bool isMint = false;
bool isJMint = false;
bool isSparkMint = false;
final bool isSparkSpend = txData["type"] == 9 && txData["version"] == 3;
final bool isSparkSpend = isSparkSpendTransaction(txData);
final bool isMySpark = sparkTxids.contains(txData["txid"] as String);
final bool isMySpentSpark = missing
.where((e) => e.txid == txData["txid"])
Expand Down
11 changes: 11 additions & 0 deletions test/wallets/firo_transaction_type_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:paymint/wallets/wallet/impl/firo_transaction_type.dart';

void main() {
test('recognizes Spark spend transaction types', () {
expect(isSparkSpendTransaction({'version': 3, 'type': 9}), isTrue);
expect(isSparkSpendTransaction({'version': 3, 'type': 11}), isTrue);
expect(isSparkSpendTransaction({'version': 3, 'type': 10}), isFalse);
expect(isSparkSpendTransaction({'version': 2, 'type': 11}), isFalse);
});
}
Loading