Docs/completion program design - #102
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5682bb4438
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Replace the SEC-010 matrix claim that cosign and uv.lock wiring remain with a state that distinguishes implementation from final qualification: | ||
|
|
||
| ```markdown | ||
| | **SEC-010** | **CI/dependency/supply-chain** | **IMPLEMENTED / FINAL-RC QUALIFICATION PENDING** | Immutable action pinning, least privilege, release/container SBOMs, per-arch SBOMs, `uv lock --check`, `uv sync --locked`, keyless cosign signing, Helm packaging/checksums, and release-tag gate are merged. Final artifact/signature/reproducibility verification is C5. | |
There was a problem hiding this comment.
Replace IMPLEMENTED / FINAL-RC QUALIFICATION PENDING with the defined IMPLEMENTED / QUALIFICATION PENDING state. The plan requires every final-release row to use only the four ledger states, so executing this prescribed replacement would immediately create a fifth state in the canonical execution plan and undermine the state-normalization and verification steps later in this document.
Useful? React with 👍 / 👎.
| | Fleet | Admission seam | INCOMPLETE / ACTIONABLE | PR #99 deliberately leaves `AdmissionGate` unwired | none | C3 | | ||
| | Agent UX | Skills install lifecycle | INCOMPLETE / ACTIONABLE | PR #81 advertises install but implementation is placeholder | none | C2 | | ||
| | Performance | Bounded performance targets | IMPLEMENTED / QUALIFICATION PENDING | `tests/unit/test_performance_targets.py` | Exact-RC execution pending | C5 | | ||
| | Governance | Main branch protection/rulesets | INCOMPLETE / ACTIONABLE | repository audit shows `protected:false` | none | C6 | |
There was a problem hiding this comment.
Add an INCOMPLETE / ACTIONABLE row for the agent/subagent lifecycle audit mapped to C4. The design defines this as a remaining completion domain and Task 2 includes C4 in the active residuals, but the required starter matrix skips directly from the C2/C3 gaps to C5/C6 items; because Task 8 validates only rows that already exist, an executor can follow this plan successfully while leaving the canonical ledger with no record of C4.
Useful? React with 👍 / 👎.
1 participant
Summary
Describe the bounded change and why it is needed.
Scope
Validation
Security review
Operations / release
Documentation
Notes for reviewers
Call out the highest-risk assumption, unresolved blocker, or follow-up slice. Do not merge while hosted verification is pending or red.