feat(inventory): open the 3d embed to sticker, patch, charm, and agent items - #414
Draft
ykns3 wants to merge 2 commits into
Draft
feat(inventory): open the 3d embed to sticker, patch, charm, and agent items#414ykns3 wants to merge 2 commits into
ykns3 wants to merge 2 commits into
Conversation
…t items The weapons/gloves scope was extension-side gating only — the item kind rides inside the masked inspect hex. Adds an inspect-requested embed event: the sandboxed iframe can't launch steam:// itself, so it forwards the Inspect click and we launch the item's own action link, pattern-pinned end to end.
Steam ships the hex two ways: skins carry it as asset property 6 with a %propid:6% slot in the action link, but stickers embed it literally in the link with no property at all. Inventory links also use steam://run/730// rather than the market rungame form — accept both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%propid:6%slot in the inspect action link (skins), or embedded literally in the action link with no property at all (stickers). Accepts both the inventorysteam://run/730//and marketsteam://rungame/730/<id>/launch forms.inspect-requestedembed event: the sandboxed iframe can't launchsteam://itself, so it forwards the Inspect click and the extension launches the shown item's own action link. No URL crosses the iframe bridge; the launch value ridesSkinCraftItem.inspectUrl, pattern-pinned to the preview-launch shape at the page → content-script boundary and re-checked before navigation.Merge order: the SkinCraft embed change (standalone subjects +
inspect-requested) must deploy first, or the new 3D tabs fail to load.Validation
npm testnpm run lintnpm run checkformatnpm run build