Skip to content

Implement auto-forget in Parquet converter lifecycle - #7752

Merged
friedrichg merged 2 commits into
masterfrom
Add-autoforgetdelay-parquet-converter
Aug 9, 2026
Merged

Implement auto-forget in Parquet converter lifecycle#7752
friedrichg merged 2 commits into
masterfrom
Add-autoforgetdelay-parquet-converter

Conversation

@SungJin1212

Copy link
Copy Markdown
Member

What this PR does:
Implement an auto-forget mechanism in the Parquet converter.
Note: This was already defined in the config, but it was a no-op.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
  • docs/configuration/v1-guarantees.md updated if this PR introduces experimental flags

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@dosubot dosubot Bot added go Pull requests that update Go code type/feature labels Aug 6, 2026

@friedrichg friedrichg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread pkg/parquetconverter/converter_test.go Outdated
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2026
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@friedrichg
friedrichg merged commit 5320fcc into master Aug 9, 2026
40 checks passed
@friedrichg
friedrichg deleted the Add-autoforgetdelay-parquet-converter branch August 9, 2026 22:21
SungJin1212 added a commit to SungJin1212/cortex that referenced this pull request Aug 10, 2026
)

* implement auto-forget in parquet converter ring lifecycler

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>

* clean annotations

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>

---------

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code lgtm This PR has been approved by a maintainer size/M type/feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants