music: add output device selection - #2056
Open
TheFallen058 wants to merge 4 commits into
Open
TheFallen058 wants to merge 4 commits into
TheFallen058 wants to merge 4 commits into
Conversation
Add protocol support and a Music app picker for selecting phone media output routes. Co-authored-by: GPT-5.6 Sol <noreply@openai.com> Signed-off-by: Aliaksandr Karnilovich <alexander.karnilovich@capital.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Advertise watch support and preserve route generations through selection. Reject malformed responses and expose an atomic snapshot to consumers. Co-authored-by: GPT-5.6 Sol <noreply@openai.com> Signed-off-by: Aliaksandr Karnilovich <alexander.karnilovich@capital.com>
Keep displayed routes stable until selection and open the picker with a long Select press in every control mode. Preserve short-press play and pause. Co-authored-by: GPT-5.6 Sol <noreply@openai.com> Signed-off-by: Aliaksandr Karnilovich <alexander.karnilovich@capital.com>
Invalidate picker snapshots when output routing becomes unavailable. Add configurable session capabilities and verify watch capability advertisement. Co-authored-by: GPT-5.6 Sol <noreply@openai.com> Signed-off-by: Aliaksandr Karnilovich <alexander.karnilovich@capital.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Allow Pebble users to change the active Android media output directly from the Music app while preserving the existing short-press play and pause controls.
This PR implements the PebbleOS side of the feature. Android performs route discovery and transfer; PebbleOS provides the picker UI and transports requests and selections over Pebble Protocol.
Companion Android PR: coredevices/mobileapp#422
Behavior
Compatibility
The picker is available only when the connected phone advertises matching support. Existing music controls remain unchanged with older mobile apps, and no additional action-bar icon is introduced.
The complete feature requires the companion Android PR. Either side independently gates unsupported peers through Pebble Protocol capabilities.
Validation
obelix@pvtclang-formatverificationgitlintverification for all feature commitsThe firmware build and focused routing tests passed locally. The complete image-comparison suite could not run locally because generated PBI/PDC fixtures were unavailable; canonical CI remains the authoritative image check.
AI disclosure
AI assistance was used for implementation and review. Usage is disclosed in the relevant commit trailers.