Add upgrade command for package management in containers - #1843
Open
silverhadch wants to merge 3 commits into
Open
silverhadch wants to merge 3 commits into
silverhadch wants to merge 3 commits into
Conversation
Toolbx doesn't try to detect the package manager. The image says how its packages are meant to be updated through a label, and Toolbx runs that command inside the container. This way, an image that Toolbx has never heard of can support the command without requiring changes to, and a new release of, Toolbx itself: com.github.containers.toolbx.package-manager.update Since the command comes from the image, and not from Toolbx, it's always shown before it's run, and, unless --assumeyes was used, the user is asked for confirmation. There is a second, optional, label with the variant of the command that doesn't ask any questions. It's only used with --assumeyes, so that there's never more than one prompt, and never a prompt that can't be answered: com.github.containers.toolbx.package-manager.update.assumeyes Images that can't be updated without user interaction leave the second label unset, and images that don't want to support the command at all leave both unset. Note that this is not the same as rebasing a container over an image for a newer operating system version. Signed-off-by: Hadi Chokr <hadichokr@icloud.com>
Signed-off-by: Hadi Chokr <hadichokr@icloud.com>
Signed-off-by: Hadi Chokr <hadichokr@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #1683
Signed-off-by: Hadi Chokr hadichokr@icloud.com