Add a Link type for printing OSC 8 hyperlinks - #295
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
djc
reviewed
Sep 1, 2026
| } | ||
|
|
||
| fn enabled(&self) -> bool { | ||
| self.force.unwrap_or_else(|| match self.for_stderr { |
Member
There was a problem hiding this comment.
Since this isn't really about color, I don't think we should disable the links for this.
Comment on lines
+951
to
+955
| if self.enabled() { | ||
| write!(f, "\x1b]8;;{}\x1b\\{}\x1b]8;;\x1b\\", self.url, self.text) | ||
| } else { | ||
| self.text.fmt(f) | ||
| } |
Member
There was a problem hiding this comment.
Nit: suggest writing this as
match self.enabled() {
true => write!(..),
false => self.text.fmt(f),
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132.
console already recognizes OSC 8 hyperlinks when stripping/measuring text, but there was no way to emit one. This adds a small
Linkwrapper, in the same spirit asEmoji, that prints text as an OSC 8 hyperlink on terminals that support it.Like styling, the escape is only written when colors are enabled for the target stream, so piped or redirected output just shows the plain text. You can force it on or off with
.force(..)and target stderr with.for_stderr().I went with
Link::new(text, url)so it reads a bit like a Markdown link, but I'm happy to flip the order if you'd rather have the url first. epage linked anstyle-hyperlink on the issue as a reference; I kept this minimal for now and left out the optionalid=parameter.