chore: add Claude pr-review skill and Copilot instructions - #3475
Draft
Dave Shoup (shouples) wants to merge 2 commits into
Draft
chore: add Claude pr-review skill and Copilot instructions#3475Dave Shoup (shouples) wants to merge 2 commits into
pr-review skill and Copilot instructions#3475Dave Shoup (shouples) wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Reorder both checklists to lead with the failure modes human reviewers actually flag (output/serialization struct design, backend-first validation, error-handling semantics, generator alignment, failure-path tests) and demote lint-owned casing/arity guidance. Based on ~340 non-Copilot PR review comments from the last four months.
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
This PR adds repo-level AI-assisted PR review tooling for the Confluent CLI, including a Claude Code PR-review skill, GitHub Copilot PR review instructions, and Claude project settings to restrict .env access.
Changes:
- Add
.github/copilot-instructions.mdto steer GitHub Copilot reviews toward the repo’s highest-impact CLI review invariants (compatibility, output/serialization, validation, error semantics, tests). - Add
.claude/skills/pr-review/SKILL.mdto provide a structured PR review checklist/process tailored to this codebase. - Add
.claude/settings.jsonto deny reading/editing.envfiles in Claude Code project context.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/copilot-instructions.md | Adds GitHub Copilot review guidance aligned to Confluent CLI conventions/checkpoints. |
| .claude/skills/pr-review/SKILL.md | Adds a Claude Code “pr-review” skill with a structured review process and repo-specific checklists. |
| .claude/settings.json | Adds Claude Code permissions to deny read/edit access to .env files. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+196
to
+197
| - `golangci-lint` owns formatting, import ordering (`gci`: stdlib → default → `confluentinc/` → | ||
| `confluentinc/cli/`), naked returns, unused code, and misspellings. Don't comment on any of it. |
pr-review skill and Copilot instructions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Release Notes
N/A - repo tooling only (
.claude/and.github/); no user-facing CLI change.Breaking Changes
Checklist
N/A - this PR adds only
.claude/and.github/review tooling. The CLI-binary build, Cloud/Platform verification, and integration-test items do not apply, and there are no breaking changes.What
Sets up AI-assisted PR review for this repo. All three files are new; there are no CLI code changes.
.claude/skills/pr-review/SKILL.md- a Claude Code skill for self-review (PR authors) and formal review (reviewers), encoding the repo's non-inferable conventions..github/copilot-instructions.md- guidance GitHub Copilot loads for its automated PR reviews..claude/settings.json- basic project-level Claude Code settings; denies reading and editing.envfiles.The two review checklists lead with the failure modes that dominated a sample of ~340 non-Copilot inline review comments from the last four months: output/serialization struct-tag design, backend-first validation, error-handling semantics, generator alignment, and failure-path test coverage - rather than the casing and argument-arity rules that
golangci-lint/lint-clialready enforce.Blast Radius
None. Affects only AI-assisted review guidance in this repo; no runtime, build, or customer impact.
References
Test & Review
The two review files were audited by the matching config agents -
claude-code-guidefor the skill,copilot-guidefor the Copilot instructions - and their findings applied (tool-name fix, de-duplicated checklist, a diff-checkable generator rule, and a before/after*Outstruct example). Markdown structure was verified (heading order, balanced code fences).