[USTORAGE-29421] Note GCP PORTABLE default in enable help text - #3459
Open
Rajendra Dangwal (rajdangwal) wants to merge 1 commit into
Open
[USTORAGE-29421] Note GCP PORTABLE default in enable help text#3459Rajendra Dangwal (rajdangwal) wants to merge 1 commit into
Rajendra Dangwal (rajdangwal) wants to merge 1 commit into
Conversation
New Google Cloud Tableflow topics default the metadata column naming scheme to PORTABLE (BigQuery-compatible cflt_metadata_ names) when the scheme is left unset; other clouds default to DEFAULT. Document this in the topic enable --metadata-column-naming-scheme help text and update the golden. The default itself is resolved server-side in cc-cts-api-service.
Copilot started reviewing on behalf of
Rajendra Dangwal (rajdangwal)
August 20, 2026 10:11
View session
There was a problem hiding this comment.
Pull request overview
Updates the confluent tableflow topic enable flag help text to document the server-resolved, per-cloud default for --metadata-column-naming-scheme when the flag is omitted, and refreshes the corresponding golden help output.
Changes:
- Extend
--metadata-column-naming-schemehelp text to state the default isPORTABLEfor new Google Cloud topics andDEFAULTfor other clouds when unset. - Update the
enable --helpgolden output fixture to match the new help text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/tableflow/command_topic_enable.go | Updates the --metadata-column-naming-scheme flag description to document per-cloud defaults when the flag is omitted. |
| test/fixtures/output/tableflow/topic/enable-help.golden | Updates the expected enable --help output to reflect the revised flag description. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Rajendra Dangwal (rajdangwal)
marked this pull request as ready for review
August 25, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the
tableflow topic enable --metadata-column-naming-schemehelp text to note that new Google Cloud topics default toPORTABLE(BigQuery-compatiblecflt_metadata_names) when the scheme is left unset, and topics on other clouds default toDEFAULT. Golden updated.Why
The per-cloud default is applied by the Tableflow publishers (cc-unified-storage#6559); this just documents it in the CLI help. No functional CLI change: the CLI still sends the field only when the user sets it.
Part of USTORAGE-29421 (epic USTORAGE-23793).