Skip to content

Fix WMQ examples (78-84) - #494

Open
mp-orkes wants to merge 9 commits into
mainfrom
fix/wmq-examples-2
Open

Fix WMQ examples (78-84)#494
mp-orkes wants to merge 9 commits into
mainfrom
fix/wmq-examples-2

Conversation

@mp-orkes

@mp-orkes mp-orkes commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Continuing the WMQ example pass from #492. Tested each against a local OSS server with WMQ enabled.

Bugs

  • 78 — crashed on worker spawn (no if __name__ == "__main__" guard), and tempfile.mkdtemp() at module level gave every worker its own IPC dir, so approval requests never reached the main process. Dir now crosses via APPROVAL_WORKFLOW_IPC_DIR.
  • 79 — dropped the last paragraph: the barrier waited on the Researcher forwarding, then stopped both agents while the Writer was still mid-turn. Now waits on publish sentinels.
  • 80, 81, 82 — docstrings named anthropic/claude-sonnet-4-20250514, which 404s. On that model 82 never replies; it works on claude-sonnet-5.

Docstrings — corrected claims that no longer match the code: the wrong tool named as 78's approval gate, a closure in 79 that #477 removed, a "no time.sleep()" claim in 82_fan_out_fan_in contradicted by the code, updateVariables named as 84's stop mechanism (it's POST /agent/{id}/stop), undocumented /disconnect and /tools in 81, and a missing WMQ requirement throughout.

Testing

78: 5 tasks through 3 approval gates, COMPLETED. 79: 3/3 paragraphs across 4 runs (was consistently 2/3). 82_fan_out_fan_in: 9/9 answers, all 5 workflows COMPLETED. 83: same domain across runtime restart, both tasks ran. 84: _stop_requested: true, COMPLETED. 82: replies correctly on claude-sonnet-5.

79 and 82_fan_out_fan_in still fail roughly 1 run in 3 on #493 (handle.stop() leaving _stop_requested false) — unrelated to these fixes.

🤖 Generated with Claude Code

mp-orkes and others added 9 commits August 14, 2026 12:58
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@mp-orkes
mp-orkes requested review from kowser-orkes and v1r3n and removed request for kowser-orkes August 14, 2026 19:46
@mp-orkes mp-orkes self-assigned this Aug 14, 2026
@mp-orkes mp-orkes changed the title Fix WMQ examples (78-79) Fix WMQ examples (78-84) Aug 14, 2026
@mp-orkes
mp-orkes marked this pull request as ready for review August 14, 2026 19:53
@mp-orkes

Copy link
Copy Markdown
Contributor Author

Reviewed and manually tested all the examples with Claude’s assistance. The coding agent examples are interactive and were validated manually.

Screenshot 2026-08-14 at 16 12 44 Screenshot 2026-08-14 at 13 59 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants