Fix WMQ examples (78-84) - #494
Open
mp-orkes wants to merge 9 commits into
Open
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mp-orkes
requested review from
kowser-orkes and
v1r3n
and removed request for
kowser-orkes
August 14, 2026 19:46
mp-orkes
marked this pull request as ready for review
August 14, 2026 19:53
Contributor
Author
kowser-orkes
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Continuing the WMQ example pass from #492. Tested each against a local OSS server with WMQ enabled.
Bugs
if __name__ == "__main__"guard), andtempfile.mkdtemp()at module level gave every worker its own IPC dir, so approval requests never reached the main process. Dir now crosses viaAPPROVAL_WORKFLOW_IPC_DIR.publishsentinels.anthropic/claude-sonnet-4-20250514, which 404s. On that model 82 never replies; it works onclaude-sonnet-5.Docstrings — corrected claims that no longer match the code: the wrong tool named as 78's approval gate, a closure in 79 that #477 removed, a "no
time.sleep()" claim in 82_fan_out_fan_in contradicted by the code,updateVariablesnamed as 84's stop mechanism (it'sPOST /agent/{id}/stop), undocumented/disconnectand/toolsin 81, and a missing WMQ requirement throughout.Testing
78: 5 tasks through 3 approval gates, COMPLETED. 79: 3/3 paragraphs across 4 runs (was consistently 2/3). 82_fan_out_fan_in: 9/9 answers, all 5 workflows COMPLETED. 83: same domain across runtime restart, both tasks ran. 84:
_stop_requested: true, COMPLETED. 82: replies correctly onclaude-sonnet-5.79 and 82_fan_out_fan_in still fail roughly 1 run in 3 on #493 (
handle.stop()leaving_stop_requestedfalse) — unrelated to these fixes.🤖 Generated with Claude Code