Skip to content

Show module path when logging tasks #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codingjoe merged 1 commit into from
Sep 5, 2026
Merged

Show module path when logging tasks #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions threadmill/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,19 @@ def retry_delay(task_result: TaskResult) -> datetime.timedelta | None:
try:
return task_result.task.retry(TaskContext(task_result=task_result))
except Exception:
logger.exception("Retry callback failed for task %r", task_result.id)
logger.exception(
"Retry callback failed for task '%s@%s'",
task_result.id,
task_result.task.module_path,
)

def execute_task_result(self, task_result: TaskResult) -> TaskResult:
"""Execute task from task result and update result lifecycle state."""
logger.info("Executing task %r", task_result.id)
logger.info(
"Executing task '%s@%s'",
task_result.id,
task_result.task.module_path,
)
started_at = timezone.now()
task_result = dataclasses.replace(
task_result,
Expand All @@ -252,7 +260,11 @@ def execute_task_result(self, task_result: TaskResult) -> TaskResult:
errors=[*task_result.errors, WorkerThread.create_task_error(exception)],
finished_at=timezone.now(),
)
logger.exception("Task failed %r", task_result.id)
logger.exception(
"Task '%s@%s' failed",
task_result.id,
task_result.task.module_path,
)
else:
task_result = dataclasses.replace(
task_result,
Expand All @@ -262,7 +274,11 @@ def execute_task_result(self, task_result: TaskResult) -> TaskResult:
object.__setattr__(
task_result, "_return_value", normalize_json(return_value)
)
logger.info("Task successful %r", task_result.id)
logger.info(
"Task '%s@%s' succeeded",
task_result.id,
task_result.task.module_path,
)
finally:
task_finished.send(TaskExecutor, task_result=task_result)

Expand Down