Fix the pypy3 kernel test name, and restrict pypy3 to Linux - #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two failures on
mainfrom #100.python (Linux)kernels.pypy3installs a kernel namedpython3, same as the CPython ones, so papermill couldn'tfind a
pypy3kernel and the runner exited 1.testHasExpectedFieldspassed because it evaluatesthe Nix attribute (
kernels."pypy3"), which really ispypy3; only the twotestKernelStdoutcalls resolve the installed kernel name.
build-sample-environments (macOS, aarch64-darwin)Enabling the pypy3 sample environment meant it stopped being an empty derivation on Darwin, and
PyPy's bootstrap interpreter doesn't build there:
I only checked #100 on Linux. The sample environment now follows the existing
optionalAttrspattern in
sample_environments.nix, and the test is gated the same way, since the kernel it needscan't be built on Darwin either.
Testing
pypy3 tests run green on Linux:
sample_environment_pypy3is present inpackages.x86_64-linuxand absent frompackages.aarch64-darwin. Test suite compiles.