fix(admin): align console pages with the shared nav, add drive status - #206
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
barunaniket
requested review from
hagemaruwu,
shivanshpap and
vaibhavtulsian
as code owners
September 8, 2026 19:32
Follow-up to #205. Extracting the nav into admin/layout.tsx left three pages that only inherit it out of step with the two that were edited. - teachers, problems/new and problems/[slug]/edit still carried `pt-6` on their own section while the layout now supplies it, so those three rendered the gap twice. - The two problem pages were `max-w-3xl` against the layout's `max-w-4xl`, so the nav sat wider than the content it heads. Widened them rather than narrowing the nav: all six console pages now share one measure, which is the point of having a shared layout. It does make the problem-authoring form slightly wider — deliberate, and admin-only. Also picks up the two panel touches from the plan that #205 left optional: - A "Preview the saved form" link, so an admin can confirm the URL they pasted is the right form *before* opening the drive to applicants. - A plain-language line saying what /join is actually serving right now. Derived from the saved row rather than the editor fields on purpose — reading the unsaved state would announce a drive as open the moment someone ticked the box, before anything was written.
barunaniket
force-pushed
the
fix/admin-nav-polish
branch
from
September 8, 2026 19:35
70d58f1 to
47e875d
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #205, as flagged in that review. Two cosmetic leftovers from the nav extraction, plus the two panel touches the plan listed as optional.
Layout consistency
Extracting the nav into
admin/layout.tsxleft the three pages that only inherit it out of step with the two that were edited:admin/teachersmax-w-4xl px-6 **pt-6** pb-24max-w-4xl px-6 pb-24admin/problems/new**max-w-3xl** px-6 **pt-6** pb-24max-w-4xl px-6 pb-24admin/problems/[slug]/edit**max-w-3xl** px-6 **pt-6** pb-24max-w-4xl px-6 pb-24pt-6now, so these three rendered the gap twice.max-w-3xlagainst the layout'smax-w-4xl.I widened the problem pages rather than narrowing the nav: all six console pages now share one measure, which is rather the point of a shared layout. Worth noting explicitly — this makes the problem-authoring form slightly wider. That's deliberate, and it's an admin-only screen.
Recruitment panel
Both were in
docs/recruitment.mdand left optional in #205:The status line is derived from the saved row, not the editor fields. That's the whole subtlety: reading unsaved state would announce a drive as open the moment someone ticked the checkbox, before anything was written. There's a comment in the code saying so.
Verified
npx tsc --noEmitclean ·npm run lint0 errors (4 pre-existing warnings, untouched files) ·npm run test90/90 ·npm run buildsucceeds.No behaviour change to the auth gates — every page keeps its own
getAdminUser()+redirect("/")andforce-dynamic, exactly as #205 left them.