refactor: Removes unused events endpoint and tests - #54
Open
tim-rohrer wants to merge 1 commit into
Open
Conversation
5 tasks
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Repository documentation still references the removed /api/v1/events endpoint and should be updated if this PR is closing #5.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes the legacy events API surface (originally used for MongoDB View POC/testing) and its supporting modules/tests to simplify the runtime API and reduce maintenance overhead.
Changes:
- Removed the
/api/v1/eventsExpress route registration fromsrc/server.ts. - Deleted the
eventscontroller/service/route layers and the MongoDB storage service for theevents-view. - Deleted Cypress E2E specs that exercised the legacy
eventsendpoint.
File summaries
| File | Description |
|---|---|
| src/storage/event.mongodb.service.ts | Deleted legacy MongoDB view access helpers for events-view. |
| src/server.ts | Stops registering the /api/v1/events route; import formatting adjustments. |
| src/events.service.ts | Deleted legacy service wrapper around event storage. |
| src/events.route.ts | Deleted legacy Express router for events. |
| src/events.controller.ts | Deleted legacy controller endpoint handler for events. |
| cypress/e2e/2-events-us-summer.cy.ts | Deleted legacy Cypress spec for events ordering behavior. |
| cypress/e2e/1-events-us-winter.cy.ts | Deleted legacy Cypress spec for events ordering behavior. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Events were originally written as a simpler way to test the MongoDB View features. As the technology matured, these lost their usefulness, and are now being removed.
We're also seeing styling changes that we'll need to track down later.
closes #5