Skip to content

ci: avoid race in wordlist-ordered task - #1085

Merged
mnencia merged 1 commit into
mainfrom
fix/wordlist-ordered-race
Aug 27, 2026
Merged

ci: avoid race in wordlist-ordered task#1085
mnencia merged 1 commit into
mainfrom
fix/wordlist-ordered-race

Conversation

@mnencia

@mnencia mnencia commented Aug 27, 2026

Copy link
Copy Markdown
Member

wordlist-ordered is a dep of both spellcheck and uncommitted, which run in parallel. go-task only writes the checksum after a task's cmds finish, so both parents could start the task concurrently: the first mv succeeded and removed .wordlist.txt.new before the second mv ran, failing CI with "No such file or directory".

Mark the task run: once so concurrent deps are deduped.

@mnencia
mnencia requested a review from a team as a code owner August 27, 2026 12:13
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Aug 27, 2026
@mnencia
mnencia force-pushed the fix/wordlist-ordered-race branch from 69265fd to 65cf721 Compare August 27, 2026 12:19
@mnencia mnencia changed the title fix(task): avoid race in wordlist-ordered task fix(ci): avoid race in wordlist-ordered task Aug 27, 2026
@mnencia
mnencia force-pushed the fix/wordlist-ordered-race branch from 65cf721 to 3c5a058 Compare August 27, 2026 12:20
@mnencia mnencia changed the title fix(ci): avoid race in wordlist-ordered task ci: avoid race in wordlist-ordered task Aug 27, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 27, 2026
The wordlist-ordered task is a dep of both spellcheck and
uncommitted, which run in parallel. go-task only writes the
checksum after a task's cmds finish, so both parents could start
the task concurrently: the first mv succeeded and removed
.wordlist.txt.new before the second mv ran, failing CI with
"No such file or directory".

Mark the task run: once so concurrent deps are deduped.

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia
mnencia force-pushed the fix/wordlist-ordered-race branch from 3c5a058 to a4b3542 Compare August 27, 2026 12:39
@mnencia
mnencia merged commit 7ffb4e9 into main Aug 27, 2026
9 checks passed
@mnencia
mnencia deleted the fix/wordlist-ordered-race branch August 27, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants