fix(server): align user agent parsing with Next.js - #3202
Open
hyoban wants to merge 3 commits into
Open
Conversation
commit: |
Contributor
Performance benchmarksCompared 2 improved · 1 regressed · 3 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Member
|
/bigbonk review for issues |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
userAgent()currently returns empty browser, device, engine, OS, and CPU objects, so the documented mobile viewport example always selects desktop. Its broad bot regex also disagrees with Next.js for agents such as WhatsApp and custom crawlers.Use
ua-parser-js@1.0.35, matching Next.js, and the same known-bot pattern. Keep parsing in a dedicated module re-exported bynext/server, including Next.js-compatible empty input and result shapes. Add 45 tests covering the upstream cases, mobile/tablet/CPU parsing, request headers, and bot classification.References:
Validation:
vp test run tests/user-agent.test.ts tests/shims.test.ts— 1,356 tests passedvp checknode scripts/sync-next-types.mjs --checknode scripts/check-shim-types.mjsvp run vinext#buildCloudflare Workers runtime comparison has not been run locally; full-suite and E2E validation are left to CI.