fix(cloudflare): tolerate staged cache propagation - #3189
Draft
james-elicx wants to merge 2 commits into
Draft
Conversation
commit: |
Member
Author
|
/bigbonk review for issues Please complete this review within 8 minutes. Review exact head 554adcd and report only actionable in-scope findings. Focus on the mixed outer/RSC build-identity propagation seen in main run 34160828052. |
Contributor
|
LGTM! |
Contributor
|
Contributor
Performance benchmarksCompared 1 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--warm-cdn-retriesbehaviorEvidence
The first production deploy after the multi-entrypoint rollout passed probe/readiness, then reached a mixed propagation state where the outer Worker matched while RSC responses still came from the prior stage: https://github.com/cloudflare/vinext/actions/runs/34160828052/job/101863108294
The previous logic stopped retrying as soon as either identity matched. The identical main SHA later warmed all 6/6 entries and promoted successfully once the response stage converged.
Validation
vp check packages/cloudflare/src/cdn-warm.ts tests/cloudflare-cdn-warm.test.ts tests/cloudflare-cdn-warm-deploy.test.tsvp test run tests/cloudflare-cdn-warm.test.ts tests/cloudflare-cdn-warm-deploy.test.ts(130 passed)