Add upstream response body filter benchmark - #973
Open
torinnd wants to merge 1 commit into
Open
Conversation
Add a Criterion benchmark for the per-call cost of ProxyHttp::upstream_response_body_filter, covering both the default implementation and a trivial override. This provides a stable baseline for evaluating changes to a per-body-chunk hot path. Run with: cargo bench -p pingora-proxy --bench noop_body_filter
torinnd
force-pushed
the
noop-body-filter-benchmark
branch
from
August 27, 2026 13:13
15cb798 to
a91d2cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Criterion benchmark for the per-call cost of ProxyHttp::upstream_response_body_filter, covering both the default implementation and a trivial override. This provides a stable baseline for evaluating changes to a per-body-chunk hot path. I opted for Criterion, as it's already used by pingora-lru; this adds it only as a dev-dependency and follows that existing benchmark pattern.
Run with:
cargo bench -p pingora-proxy --bench noop_body_filter