feat(nginx-strangler): cut over logs and system/plugins routes to server-nestjs - #2724
Draft
shikanime wants to merge 1 commit into
Draft
feat(nginx-strangler): cut over logs and system/plugins routes to server-nestjs#2724shikanime wants to merge 1 commit into
shikanime wants to merge 1 commit into
Conversation
…ver-nestjs Route /api/v1/logs and /api/v1/system/plugins to the NestJS backend: both modules are ported with route and guard parity (ListSystem/ManageSystem) and carry no legacy hook.* to bridge. /api/v1/system/settings stays on legacy until its missing admin guard is fixed (#2722); /api/v1/admin/roles until the adminRole event bridge exists (#2723). Rollback per README: comment the block, then nginx -s reload. Refs #2208 #1889 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Ibf007517c18bea4d321131c0cee9938c6a6a6964
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (24.10% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#1889 (suivi modularisation) ; #2208 (livraison system/config, clôturée)
Quel est le comportement actuel ?
/api/v1/logset/api/v1/system/pluginssont servies par le backend Fastify legacy via le catch-all/api/de nginx-strangler, alors que leurs modules NestJS (LogModule,SystemConfigModule) sont portés, enregistrés dansmain.module.ts, avec parité de routes et de gardes (ListSystem/ManageSystem) et sanshook.*legacy à bridger.Quel est le nouveau comportement ?
Ces deux routes sont basculées vers server-nestjs dans
routing.conf(Vague 1) :# [Vague 1 - log] 2026-09-11→location /api/v1/logsversserver-nestjs# [Vague 1 - system/config] 2026-09-11→location /api/v1/system/pluginsversserver-nestjsRollback selon le README : commenter le bloc (
# ROLLBACK AAAA-MM-JJ) puisnginx -s reload.Ne sont pas basculées, bloquées volontairement :
/api/v1/system/settings— lePOSTNestJS n'a pas la gardeManageSystem(🐛 [BUG] - server-nestjs : POST /api/v1/system/settings sans garde d'administration (bloque la bascule) #2722) ;/api/v1/admin/roles— les événementsadminRole.*n'ont pas de consommateur (🐛 [BUG] server-nestjs: adminRole.upsert/delete events have no consumer (Keycloak/GitLab admin sync dead) — cutover blocker #2723).Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Audit de parité pré-bascule : contrats partagés (
@ts-rest) = parité structurelle des chemins ; statuts/réponses vérifiés (204 no-content sur POST plugins des deux côtés) ; guards comparés route par route contre les routers legacy.