fix(server-nestjs): consume projectMember events in gitlab module - #2721
Draft
shikanime wants to merge 1 commit into
Draft
fix(server-nestjs): consume projectMember events in gitlab module#2721shikanime wants to merge 1 commit into
shikanime wants to merge 1 commit into
Conversation
projectMember.upsert/delete were emitted with no @onevent consumer, so GitLab group member sync silently stopped on the /api/v1/projects routes already cut over to server-nestjs. Add a gitlab consumer that reconciles the project group members on upsert (parity with the legacy main step) and removes the group member on delete (parity with the legacy post step; absent user or group tolerated as OK). Refs #2590 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I258b7d5035b1d05946e851297ec3a1376a6a6964
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2590 (fermeture délibérée après fusion, sur vérification du ledger)
Quel est le comportement actuel ?
project-members.service.tsémetprojectMember.upsert/projectMember.deleteviaAppEventsService, mais aucun consommateur@OnEvent('projectMember.*')n'existe dans server-nestjs : les événements sont émis sans effet et la synchronisation des membres du groupe GitLab ne se fait plus sur les routes déjà basculées (/api/v1/projects).Quel est le nouveau comportement ?
Le module gitlab consomme les deux événements :
projectMember.upsert→ re-synchronisation complète des membres du groupe GitLab du projet (réutiliseensureProjectGroupMembers), en parité avec l'étapemaindu hook legacyupsertProjectMember;projectMember.delete→ suppression ciblée du membre du groupe (résolution email → utilisateur GitLab, puisremoveGroupMember) ; utilisateur ou groupe absent de GitLab = OK, en parité avec l'étapepostdu hook legacydeleteProjectMember.Les trois sites d'émission restent inchangés. Les résultats passent par
capturePluginResult(échec → KO tracé dans le journal admin), comme les consommateursproject.*existants.Cette PR introduit-elle un breaking change ?
Non.
Autres informations