fix: disable workspace package injection to restore link: layout - #2717
Draft
shikanime wants to merge 2 commits into
Draft
fix: disable workspace package injection to restore link: layout#2717shikanime wants to merge 2 commits into
shikanime wants to merge 2 commits into
Conversation
shikanime
marked this pull request as draft
September 11, 2026 13:49
shikanime
force-pushed
the
fix/workspace-package-injection
branch
from
September 11, 2026 14:07
e806869 to
55085e7
Compare
The fa0677c lock refresh materialized injectWorkspacePackages as file: copies; install-time snapshots lack the build-generated types/ dirs, breaking keycloak-plugin dependents (TS2307/TS2741/TS2339) on cold caches. Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I2c4fc9558c697e19ca614e6e7d4e09366a6a6964 fix: force legacy pnpm deploy in server Dockerfiles pnpm v10+ restricts deploy to injected workspaces; with injectWorkspacePackages disabled the deploy step fails with ERR_PNPM_DEPLOY_NONINJECTED_WORKSPACE. --legacy restores the pre-v10 deploy path. Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I20c7b40edd0bb69676168ff45a3a50c06a6a6964 fix(server-nestjs): make the gitlab mirror rotation test deterministic Draw the vault secret age with faker.date.birthdate({min: 1, max: 2, mode: 'age'}): the draw always lands 1-2 years past, beyond the 250-day rotation threshold, so the rotation branch fires deterministically instead of failing ~1 run in 3. Refs #2706 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I28e75a5704c2d7f9f964bb5315b592946a6a6964
Draw the secret age with faker.date.birthdate({min:1, max:2, mode:'age'}): always 1-2 years past, beyond the 250-day rotation threshold, so the rotation branch fires deterministically.
Refs #2706
Co-authored-by: Automata <automata@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: I73bd8e79f76b28102a82d8e2d24b3c306a6a6964
shikanime
force-pushed
the
fix/workspace-package-injection
branch
from
September 11, 2026 14:23
55085e7 to
b9d9ee6
Compare
Member
Author
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (24.10% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quel est le comportement actuel ?
Le lockfile de main (après le revert lockfile-only) embarque
injectWorkspacePackages: truedans son blocsettings: pnpm 11 persiste ce drapeau danspnpm-lock.yaml, donc toutes les installations (locale, CI, Docker) restent en mode copies injectées. Les copiesfile:des packages workspace sont prises à l'install et ne contiennent pas lestypes/générés à la construction — le build Docker deapps/serveréchoue sur un store froid (TS2307 types/class.jsvia sonarqube,TS2339harbor sur arm64).Quel est le nouveau comportement ?
injectWorkspacePackages: falsedanspnpm-workspace.yaml+ lockfile régénéré : les importers repassent enlink:(symlinks vivants), le blocsettingsdu lockfile enregistre le drapeau àfalse. Séquence CI exacte validée localement :pnpm install --frozen-lockfileOK,pnpm --filter "./packages/**" buildOK,pnpm --filter "./plugins/**" buildOK (sonarqube + harbor inclus). Les bumps de sécurité de fa0677c sont conservés.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Un revert lockfile-only seul ne suffit pas : le drapeau vit dans le lockfile lui-même et se ré-applique à chaque résolution.