Skip to content

test(sql-parser): add multi-row column-explicit INSERT negative literal test coverage (#4659) - #5932

Open
Tyagiquamar wants to merge 1 commit into
clockworklabs:masterfrom
Tyagiquamar:test-signed-numeric-literals-insert
Open

Tyagiquamar wants to merge 1 commit into
clockworklabs:masterfrom
Tyagiquamar:test-signed-numeric-literals-insert

Conversation

@Tyagiquamar

Copy link
Copy Markdown

Summary

Adds explicit test cases verifying multi-row and column-explicit \INSERT\ statements containing negative numeric literals (e.g. \INSERT INTO t (a, b) VALUES (-1, -2), (+3, -4.5)) are correctly handled by \spacetimedb-sql-parser.

Closes #4659

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Tyagiquamar

Copy link
Copy Markdown
Author

Hi, just following up on this when you get a chance. The branch is up to date and checks are green. If it looks good from your side, it should be ready to merge. Happy to make any changes if needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL parser rejects negative numeric literals in INSERT statements

2 participants