MiniMax H3 mmproj support for Qwen3 VL 32B GGUFs - #473
Open
Nif00 wants to merge 39 commits into
Open
Conversation
- fix tokenizer model_type assignment (was comparison) - fix cast_bias_weight call signature in embedding forward
- add resolve_full_path helper to centralize path lookup - add resolve_clip_path with smart fallback logic - fix mutable default argument in update_folder_names_and_paths - add FileNotFoundError with descriptive messages - apply pep8 formatting for consistency
Add _dropdown() and _ensure_dropdown() helper functions to provide consistent dropdown configuration format expected by ComfyUI frontend in newer builds. Update all GGUF loader classes (UnetLoaderGGUF, UnetLoaderGGUFAdvanced, CLIPLoaderGGUF, DualCLIPLoaderGGUF, TripleCLIPLoaderGGUF, QuadrupleCLIPLoaderGGUF) to use the new helpers, ensuring proper frontend dropdown formatting with default value support.
Vibe code. To be reviewed.
If in dynamic mode, load GGUF as a QT.
Refactor this to support the new reconstructability protocol in the comfy core. This is needed for DynamicVRAM (to support legacy demotion for fallbacks). Add the logic for dynamic_vram construction. This is also needed for worksplit multi-gpu branch where the model is deep-cloned via reconstruction to put the model on two parallel GPUs.
Refactor this to support the new reconstructability protocol in the comfy core. This is needed for DynamicVRAM (to support legacy demotion for fallbacks). Add the logic for dynamic_vram construction. This is also needed for worksplit multi-gpu branch where the model is deep-cloned via reconstruction to put the model on two parallel GPUs.
Factor this out to a helper and implement the new core reconstruction protocol. Consider the mmap_released flag 1:1 with the underlying model such that it moves with the base model in model_override.
…XXS, IQ3_S Implements native PyTorch dequantization functions for lower IQ quant types, replacing the slow numpy fallback path for models quantized with these formats (e.g. Unsloth UD quants used as text encoders). All six new functions are verified against gguf.quants.dequantize() reference.
Co-authored-by: Cursor <cursoragent@cursor.com>
Pr/upstream cherrypicks fixes
feat: add torch dequantization for IQ1_S, IQ1_M, IQ2_XXS, IQ2_S, IQ3_…
Add Ideogram 4 architecture support for GGUF loading
Handle WeightAdapters in ops.move_patch_to_device
m8rr
added a commit
to m8rr/ComfyUI-GGUF
that referenced
this pull request
Aug 5, 2026
ChrisColeTech
added a commit
to ChrisColeTech/ComfyUI-GGUF-Loader
that referenced
this pull request
Aug 12, 2026
Cherry-pick production fixes from city96/ComfyUI-GGUF open PRs: - city96#472 dequant device-constant cache (major LTX/sampling speedup) - city96#433 IQ1/IQ2/IQ3 torch dequant (extra TE quants) - city96#470 QK-norm .scale→.weight (silent NaN/black Flux-compat) - city96#467 dequant bare nn.Parameters (LTX learnable_registers) - city96#392 lumina2/zimage pad token shape fix - city96#456/city96#468 GGMLTensor dtype + dequantize() for core cast path - city96#461 WeightAdapter-aware move_patch_to_device - city96#469 force_patch on partial load/unload - city96#440/city96#436 mistral3 TE, city96#438 qwen35, qwen2 allowlist - city96#473 partial: Qwen3-VL deepstack mmproj map for MiniMax H3 TE Skipped mega/draft rewrites (city96#459, full city96#473 LazyGGUFReader, city96#336 Triton). See PR_BACKPORT.md for the full matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.