Conversation
Covers UPL-56: create a group via the UI, view the member list and generate an invite link as creator, a second user joining through the invite link, a non-member being unable to see the group, and leaving a group removing it from the member's list. The invite token is read off the outgoing group_invites insert request rather than the clipboard, since clipboard permissions are flaky across browser projects. Also drops the stale "Boom Voter" app name from tests/README.md and lists the new spec under Current Tests. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DmUTze8TySxL9dXuFTbqrp
Documents the deliberate rename-test gap inline (no rename feature exists anywhere in the app), closes the "access the invite link" gap by asserting it shows up in Active Invites, promotes the email -> username derivation into a shared usernameFromEmail export in login.ts instead of reimplementing it locally, and extracts the repeated context/page/signIn setup into a newSignedInPage helper. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DmUTze8TySxL9dXuFTbqrp
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The invite flow test must exercise the generated URL and root-route redirect.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Playwright E2E coverage for the group lifecycle and updates test documentation and helpers.
Changes:
- Adds group creation, invitation, joining, access-control, and leaving tests.
- Adds a shared test username helper.
- Updates branding and documented test coverage.
File summaries
| File | Summary |
|---|---|
tests/utils/login.ts |
Adds reusable username derivation. |
tests/README.md |
Updates branding and coverage documentation. |
tests/e2e/groups-flow.spec.ts |
Adds group lifecycle E2E coverage; the invite test bypasses the generated root-route redirect and should use the generated URL shape. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| response.url().includes("/rest/v1/rpc/use_invite_token") && | ||
| response.ok(), | ||
| ); | ||
| await joinerPage.goto(`/invite?token=${inviteToken}`); |
Playwright test results
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Playwright e2e spec covering the group lifecycle (UPL-56): create, view members, generate/access an invite link, a second user joining via invite, a non-member being unable to see the group, and leaving a group. Also fixes the stale "Boom Voter" app name in
tests/README.md.Note: the ticket's "manage (rename)" behavior isn't tested — there's no rename-group feature anywhere in the app (no UI, mutation hook, or API route;
groupsonly supports the archived-flag soft-delete). Flagging this back to the ticket rather than silently dropping it.Verification
pnpm run test:setupthenpnpm exec playwright test tests/e2e/groups-flow.spec.ts— all 5 tests pass, deterministic across repeated runs.pnpm run lint,pnpm run typecheck,pnpm testall pass (already run in this environment; the e2e run itself needs a local Supabase/Docker stack this sandbox doesn't have, so CI is the first real run of it).🤖 Generated with Claude Code
https://claude.ai/code/session_01DmUTze8TySxL9dXuFTbqrp
Generated by Claude Code