Skip to content

WebUiScreen: Fix duplicate javascript console log messages #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenxiaolong merged 1 commit into from
Sep 13, 2026
+35 −0
Merged

WebUiScreen: Fix duplicate javascript console log messages #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions app/src/main/java/com/chiller3/basicsync/settings/WebUiScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ import android.provider.Settings
import android.util.Base64
import android.util.Log
import android.view.ViewGroup
import android.webkit.ConsoleMessage
import android.webkit.JavascriptInterface
import android.webkit.SslErrorHandler
import android.webkit.WebChromeClient
import android.webkit.WebResourceRequest
import android.webkit.WebSettings
import android.webkit.WebView
Expand Down Expand Up @@ -451,6 +453,38 @@ fun WebUiScreen(onExit: () -> Unit) {
}
}

val webChromeClient = remember {
object : WebChromeClient() {
override fun onConsoleMessage(consoleMessage: ConsoleMessage): Boolean {
/*
* Chromium sends console messages to its own logger by default [0]. On Android,
* high severity log messages get sent to both logcat and stderr [1]. Due to
* gomobile hijacking stderr [2] to send output to logcat, this causes the log
* message to be duplicated. We'll just consume the message and log ourselves to
* work around this.
*
* [0] https://source.chromium.org/chromium/chromium/src/+/main:components/headless/console_message_logger/headless_console_message_logger.cc;l=28-50;drc=aaa5ca21ac213cc0a868a387868764f63dc5e45f
* [1] https://source.chromium.org/chromium/chromium/src/+/main:base/logging.cc;l=807-865;drc=0b1e750672ddd755453dbbeec5ce9ef50c879e08
* [2] https://github.com/golang/mobile/blob/8b95e45f8d3e224183cc3d760609cef9896e498c/internal/mobileinit/mobileinit_android.go#L78-L81
*/

val logLevel = when (consoleMessage.messageLevel()) {
ConsoleMessage.MessageLevel.TIP, ConsoleMessage.MessageLevel.LOG -> Log.INFO
ConsoleMessage.MessageLevel.WARNING -> Log.WARN
ConsoleMessage.MessageLevel.ERROR -> Log.ERROR
ConsoleMessage.MessageLevel.DEBUG -> Log.DEBUG
}

val sourceId = consoleMessage.sourceId()
val lineNumber = consoleMessage.lineNumber()
val message = consoleMessage.message()

Log.println(logLevel, "SyncthingJs", "[$sourceId:$lineNumber] $message")
return true
}
}
}

AppScreen(fullScreenContent = true) { params ->
AndroidView(
factory = {
Expand Down Expand Up @@ -482,6 +516,7 @@ fun WebUiScreen(onExit: () -> Unit) {
addJavascriptInterface(webViewInterface, "BasicSync")

this.webViewClient = webViewClient
this.webChromeClient = webChromeClient
}
},
onRelease = {
Expand Down